• exec/emailval.js

    From Deuc¿@VERT to Git commit to main/sbbs/master on Thursday, October 23, 2025 17:57:27
    https://gitlab.synchro.net/main/sbbs/-/commit/1c123cf4a26eb8b42f57af4a
    Modified Files:
    exec/emailval.js
    Log Message:
    Allow valid_chars to be a string of digits

    By default, an ini value made up of all digits is a number, the
    only way to get it as a string is to pass a default whose type is
    a string.

    In the case where valid_chars is a number, re-parse with a string
    default...
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sunday, January 04, 2026 02:35:53
    https://gitlab.synchro.net/main/sbbs/-/commit/662b2dad086d767dbc6cccf7
    Modified Files:
    exec/emailval.js
    Log Message:
    Use user properties instead of user comment to store secret code

    The secret code isn't cleared after it's validated, but it didn't appear to
    be cleared before this change either (the comment retained the code).

    Removed all references to "telnet" and "telval".

    If the user's security level is not still at "level_before_validation" at the time of validation, don't change (possibly downgrading!) their level.

    I would think a property indicating that the user is validated rather than based on level (what if you want to add flags, but not change their level?) would be better.

    I'm not too thrilled about the email being sent from "sysop", but didn't
    change that.

    The string returned from new Date() can be really long with the platform specific timezone string, so that should probably be fixed too.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sunday, January 04, 2026 02:35:53
    https://gitlab.synchro.net/main/sbbs/-/commit/76304802c1359e0122c8ecc1
    Modified Files:
    exec/emailval.js
    Log Message:
    Don't always change user level, many new options, more detail in user-props

    General improvements:
    - Never reduces a user's level
    - Don't allow user to change to an unsupported netmail address
    - Use console.getkeys() for good command prompt behavior (no more "Invalid Selections")
    - Use LEN_NETMAIL instead of copied magic number

    New security options:
    - level_requiring_validation (users at or below must be validated, once)
    - credits_added_after_validation
    - minutes_added_after_validation

    Custom display message options (could be using gettext() instead):
    - prompt
    - entercode
    - nomatch
    - validated
    - goodbye

    The 'validated' state is now stored in the user props along with the code
    (as before), the date/time it was emailed and the address it was emailed
    to.

    There's still a lot of room for improvement in this script.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sunday, March 01, 2026 00:53:52
    https://gitlab.synchro.net/main/sbbs/-/commit/17b044587f7de46fd3e7f688
    Modified Files:
    exec/emailval.js
    Log Message:
    Usability improvements, use available/appropraite JS libs

    Support text/menu/emailval.* optional menu/header file

    Don't display [V]alidate option if no code has been sent.
    Dont' display [S]end option if netmail address isn't supported.

    Support -test argument to display menu even for user that's already been validated (e.g. for sysop testing).

    Use user_info_prompts JS library for prompting for netmail address.

    correct usage of console.getkeys() to not allow numeric input at this prompt. ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sunday, March 01, 2026 22:46:53
    https://gitlab.synchro.net/main/sbbs/-/commit/ce14c362a41d862dfbd87b6a
    Modified Files:
    exec/emailval.js
    Log Message:
    Don't allow a blank valid_chars options to break this module

    the default ctrl/modopts/emailval.ini has the key 'valid_chars' set to
    nothing, just as an example/documentation, but that had the effect of setting the valid chars to a blank string (no valid code chars). This fixes that.

    So when a sysop recently told me the code wasn't sent, what they actually
    meant was that no code (or a blank code) was being generated.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sunday, March 01, 2026 23:09:23
    https://gitlab.synchro.net/main/sbbs/-/commit/bd51e50de7d49a925aef2cfc
    Modified Files:
    exec/emailval.js
    Log Message:
    Force the code to be read from userprops (.ini) as a string

    Some codes may be digits only but need to read as a string
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net